Loading...

All project content is available for reading, but you need to be a member of the project for Subversion checkout of source code, or to create/modify any information.
Login if you are a member. Apply here to request membership (open to all).

Ticket #24 (closed enhancement: fixed)

Opened 11 years ago

Last modified 11 years ago

Avoid using FindPagesWithCriteria to build the PageDataCollection in the MultiPageProperty

Reported by: steve@… Owned by: jerms55@…
Priority: major Component: MultiPageProperty
Keywords: Cc: steve@…

Description

The SelectedPages metod in PropertyMultiPage.cs uses the FindPagesWithCriteria method to locate the pages stored in the xml.

The FindPagesWithCriteria method can be quite resource consuming, and could kill performance on a high traffic site with many lists.

We really do not need to find the pages in that way. A PageReference.ParseUrl(...) should take care of the url parsing, and then doing a GetPage would suffice.

If the page has been deleted, the GetPage will fail, which we can catch. If the currently logged on user does not have the neccessary access rights to see the page, we can catch that too. In both cases, the page should not be part of the PageDataCollection returned.

Change History

comment:1 Changed 11 years ago by jerms55@…

  • Owner changed from steve@… to jerms55@…
  • Status changed from new to assigned

I will update the property as suggested in have the change ready in a day.

comment:2 Changed 11 years ago by jerms55@…

  • Cc steve@… added; jerms55@… removed
  • Status changed from assigned to closed
  • Resolution set to fixed

The property has been updated to use the suggested approach. I have tested the change and it seems to work fine for user's that don't have access to pages in the list.

Note: See HelpUser/Tickets for help on using tickets.